Skip to content

feat(submitqueue): Publish request hook events from the gateway to the orchestrator's hook stage - #1107

Open
roychying wants to merge 2 commits into
mainfrom
chenghan.ying/sq-gateway-hook-publishing
Open

roychying wants to merge 2 commits into
mainfrom
chenghan.ying/sq-gateway-hook-publishing

Conversation

@roychying

@roychying roychying commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Why?

The parent PR (#1016) lets the gateway's request materializer publish request hook events, but nothing turns it on. The SubmitQueue domain already has one hook topic, submitqueue-hook, and a stage that consumes it in the orchestrator pipeline. The gateway shares that queue backend, so it can publish there rather than run a second hook stage of its own.

What?

  • The OSS gateway server registers submitqueue-hook as a publish-only topic and builds the materializer with WithHookPublishing. Both Land and the log consumers then publish request events.
  • A test checks that every topic the gateway publishes to matches the orchestrator stage's name: start, cancel and the hook topic. Renaming one side without the other fails CI instead of silently stranding messages.
  • Docs:
    • Hook RFC: the status, plus a decision bullet on why SubmitQueue request events follow the gateway summary and what that costs.
    • Workflow RFC: who publishes to the hook stage.
    • Gateway README: a short section on request hook events.

service/submitqueue/orchestrator/server still resolves every event to noop, so OSS behavior is unchanged apart from the extra messages. The comment hook follows in an internal deployment.

Test Plan

  • bazel test //service/submitqueue/gateway/server/..., including the new topic-name test.
  • make lint check-gazelle check-mocks

Issue

@roychying
roychying marked this pull request as ready for review November 17, 2026 05:10
@roychying
roychying force-pushed the chenghan.ying/sq-gateway-hook-publishing branch from d8c8cca to a93bdaf Compare November 17, 2026 06:30
@roychying
roychying force-pushed the chenghan.ying/sq-gateway-hook-publishing branch from a93bdaf to 417fb9b Compare November 17, 2026 08:12

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant