Repository navigation
feat(submitqueue): Publish request hook events from the gateway to the orchestrator's hook stage - #1107
Open
roychying wants to merge 2 commits into
Open
feat(submitqueue): Publish request hook events from the gateway to the orchestrator's hook stage#1107roychying wants to merge 2 commits into
roychying wants to merge 2 commits into
Conversation
roychying
marked this pull request as ready for review
November 17, 2026 05:10
roychying
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
November 17, 2026 05:10
roychying
force-pushed
the
chenghan.ying/sq-gateway-hook-publishing
branch
from
November 17, 2026 06:30
d8c8cca to
a93bdaf
Compare
…ateway's request materializer
…e orchestrator's hook stage
roychying
force-pushed
the
chenghan.ying/sq-gateway-hook-publishing
branch
from
November 17, 2026 08:12
a93bdaf to
417fb9b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The parent PR (#1016) lets the gateway's request materializer publish request hook events, but nothing turns it on. The SubmitQueue domain already has one hook topic,
submitqueue-hook, and a stage that consumes it in the orchestrator pipeline. The gateway shares that queue backend, so it can publish there rather than run a second hook stage of its own.What?
submitqueue-hookas a publish-only topic and builds the materializer withWithHookPublishing. BothLandand the log consumers then publish request events.start,canceland the hook topic. Renaming one side without the other fails CI instead of silently stranding messages.service/submitqueue/orchestrator/serverstill resolves every event to noop, so OSS behavior is unchanged apart from the extra messages. The comment hook follows in an internal deployment.Test Plan
bazel test //service/submitqueue/gateway/server/..., including the new topic-name test.make lint check-gazelle check-mocksIssue