Skip to content

fix(integrations): address release review findings on the sweep - #10098

Merged
waleedlatif1 merged 2 commits into
stagingfrom
sweep3/release-review
Nov 16, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
sweep3/release-review

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Fixes six review findings on the release PR (#10094) that touch the integration sweep. Each one was independently verified by running the real tool-call pipeline. Four other findings on the sweep were declined in their threads, with traces.

  • Search and replace: a tool row's filter builder is stored as JSON text, and search treated that text as one searchable leaf. A replace could therefore rewrite rule keys such as operator or column and break the rule. The filter builder is now a JSON-array value field, so only rule value text is searchable. The tool-row param is still written back as text, and canvas matches and replacements are unchanged. This removes the now-unused TEXT_VALUE_ONLY_SUBBLOCK_TYPES guard, because both of its types are now JSON value fields. The bug predates the sweep.
  • Perplexity: a canvas Temperature of numeric 0 is now sent instead of dropped.
  • Mailgun Add List Member: on a tool call, the mapper uses pinnedParams to tell the row's saved List Address (stored under the tool's address id) from a member address the model sent. This replaces the equality heuristic. When no member can be determined, the tool's required-param check fails clearly instead of adding the list address as a member. Canvas output is unchanged.
  • SailPoint: normalizeStringList accepts a lone number or boolean (for example a JSON-parsed searchAfter of 12345) and null, instead of crashing on .trim().
  • Resend Create Broadcast: Audience ID is required again in the editor when no Segment ID is set. The sweep made it optional for segment sends. The tool's runtime check is unchanged.
  • Affinity: on tool calls, a model's rank/winRate now goes through the same validation whenever the block field is blank. The mapper is wrapped in failToolCallOnError, so a validation error fails the call instead of falling back to raw params. Canvas output is unchanged.

Release notes

  • Saved Perplexity workflows with Temperature set to 0 now send temperature: 0 instead of the provider default.
  • Search and replace no longer edits the structure of filter rules saved on Agent tool rows; it only matches rule values.
  • Mailgun Add List Member, used as an Agent tool with the List Address saved on the row, no longer adds the list address as a member.
  • Affinity dropdown option writes from an Agent reject an invalid rank or win rate instead of sending it.

Testing

  • Each fix has a regression test that fails on the pre-fix code: affinity, mailgun, perplexity, resend and sailpoint block tests, plus search-replace replacements.test.ts. Tool-call cases run without an operation in params, the way the Agent path calls the mapper.
  • bun run test on the touched suites (115 tests), biome, check:mapper-operation, check:tool-metadata, check:docs and check:explicit-any all pass locally.

@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 16, 2026 9:53pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 13 files

Confidence score: 3/5

  • In mailgun.ts, saved List Address params can make valid Agent add-member calls lose the model’s required address. Preserve the Agent-supplied address in this mode.
  • In resend.ts, the catalog calls the new required function without arguments, so it can publish audienceId as required for create_broadcast. Align the catalog projection with the intended requirement.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/sim/blocks/blocks/resend.ts">

<violation number="1" location="apps/sim/blocks/blocks/resend.ts:320">
P2: The new `required` function is also called with no arguments by the catalog projection (`lib/catalog/projection/subblock.ts`), which publishes `requiredWhen` for `audienceId` as including `create_broadcast`. That is wrong when a Segment ID is set, since the tool accepts a segment alone. Consider publishing a static condition that excludes create_broadcast, or handling the no-values case in the projection so the public catalog matches runtime behavior.</violation>
</file>

<file name="apps/sim/blocks/blocks/mailgun.ts">

<violation number="1" location="apps/sim/blocks/blocks/mailgun.ts:418">
P1: A saved List Address makes valid Agent add-member calls lose the model's required `address`: saved params override model args before this mapper, then `addressIsList` forces `address` to `undefined`. Preserve the model's member argument separately from the saved list address, rather than relying on the undeclared `memberAddress` field.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/blocks/blocks/mailgun.ts Resolved
Comment thread apps/sim/blocks/blocks/resend.ts Resolved
@greptile-apps

greptile-apps Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The changes since the previous review appear safe to merge.

Summary

This PR fixes filter-value replacements and input mapping for five integrations.

  • Search and replace changes filter values without rewriting rule keys.
  • Mailgun tool calls separate the saved list address from the member address.
  • Affinity dropdown writes validate model rank and win rate values.
  • Resend requires an Audience ID when a broadcast has no segment.
  • SailPoint list inputs accept lone numbers, booleans, and null.
  • Perplexity chat sends a canvas temperature of zero.

Reviews (2) · Last reviewed commit: "fix(resend): keep the catalog's audience..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 13 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit e5cbc17 into staging Nov 16, 2026
82 checks passed
@waleedlatif1
waleedlatif1 deleted the sweep3/release-review branch November 16, 2026 22:06

This branch was previously deployed

1 inactive deployment
Preview — 39a4fdac Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant