Repository navigation
fix(integrations): address release review findings on the sweep - #10098
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
There was a problem hiding this comment.
2 issues found across 13 files
Confidence score: 3/5
- In
mailgun.ts, saved List Address params can make valid Agent add-member calls lose the model’s requiredaddress. Preserve the Agent-supplied address in this mode. - In
resend.ts, the catalog calls the newrequiredfunction without arguments, so it can publishaudienceIdas required forcreate_broadcast. Align the catalog projection with the intended requirement.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/blocks/blocks/resend.ts">
<violation number="1" location="apps/sim/blocks/blocks/resend.ts:320">
P2: The new `required` function is also called with no arguments by the catalog projection (`lib/catalog/projection/subblock.ts`), which publishes `requiredWhen` for `audienceId` as including `create_broadcast`. That is wrong when a Segment ID is set, since the tool accepts a segment alone. Consider publishing a static condition that excludes create_broadcast, or handling the no-values case in the projection so the public catalog matches runtime behavior.</violation>
</file>
<file name="apps/sim/blocks/blocks/mailgun.ts">
<violation number="1" location="apps/sim/blocks/blocks/mailgun.ts:418">
P1: A saved List Address makes valid Agent add-member calls lose the model's required `address`: saved params override model args before this mapper, then `addressIsList` forces `address` to `undefined`. Preserve the model's member argument separately from the saved list address, rather than relying on the undeclared `memberAddress` field.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Contributor
[Medium impact] The changes since the previous review appear safe to merge. SummaryThis PR fixes filter-value replacements and input mapping for five integrations.
Reviews (2) · Last reviewed commit: "fix(resend): keep the catalog's audience..." · Reviewed by Greptile |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes six review findings on the release PR (#10094) that touch the integration sweep. Each one was independently verified by running the real tool-call pipeline. Four other findings on the sweep were declined in their threads, with traces.
operatororcolumnand break the rule. The filter builder is now a JSON-array value field, so only rulevaluetext is searchable. The tool-row param is still written back as text, and canvas matches and replacements are unchanged. This removes the now-unusedTEXT_VALUE_ONLY_SUBBLOCK_TYPESguard, because both of its types are now JSON value fields. The bug predates the sweep.0is now sent instead of dropped.pinnedParamsto tell the row's saved List Address (stored under the tool'saddressid) from a member address the model sent. This replaces the equality heuristic. When no member can be determined, the tool's required-param check fails clearly instead of adding the list address as a member. Canvas output is unchanged.normalizeStringListaccepts a lone number or boolean (for example a JSON-parsedsearchAfterof12345) andnull, instead of crashing on.trim().rank/winRatenow goes through the same validation whenever the block field is blank. The mapper is wrapped infailToolCallOnError, so a validation error fails the call instead of falling back to raw params. Canvas output is unchanged.Release notes
temperature: 0instead of the provider default.Testing
replacements.test.ts. Tool-call cases run without an operation in params, the way the Agent path calls the mapper.bun run teston the touched suites (115 tests), biome,check:mapper-operation,check:tool-metadata,check:docsandcheck:explicit-anyall pass locally.