Skip to content

feat: post CI results in PRs - #684

Draft
avivkeller wants to merge 12 commits into
nodejs:mainfrom
avivkeller:jenkins-pr-status
Draft

avivkeller wants to merge 12 commits into
nodejs:mainfrom
avivkeller:jenkins-pr-status

Conversation

@avivkeller

@avivkeller avivkeller commented Aug 15, 2026 •

Copy link
Copy Markdown
Member

Comment thread lib/jenkins-ci-results.js Resolved
@Trott

Trott commented Sep 22, 2026

Copy link
Copy Markdown
Member

This needs a rebase (and a review from someone on @nodejs/github-bot, which I suppose could be me!).

@christianaurichzm christianaurichzm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! As a contributor without Jenkins access who wants to keep contributing, this would help me a lot. Often it's just a flaky test, but it's hard to be sure without the logs, and I don't love pinging people about it on every PR. Left a few comments.

Comment thread lib/jenkins-ci-results.js Resolved
Comment thread lib/jenkins-ci-results.js Resolved
Comment thread lib/push-jenkins-update.js Resolved
Comment thread package.json Resolved
Signed-off-by: avivkeller <me@aviv.sh>
@Trott
Trott force-pushed the jenkins-pr-status branch from 19175c0 to 34958d0 Compare November 14, 2026 16:20

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@Trott
Trott requested a balanced review from Copilot November 14, 2026 20:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Human assessment is needed because unpublished findings identify critical Markdown injection risks in bot-authored comments and truncation errors that can leave diagnostic markup unclosed.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@Trott

Trott commented Nov 14, 2026

Copy link
Copy Markdown
Member

I'm going to put this in draft mode because I think we need some changes to node-core-utils first.

@Trott
Trott marked this pull request as draft November 14, 2026 20:32

@Trott Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to wait for some changes in node-core-utils.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show CI failure details to non-collaborator PR authors RFC: update Pull Requests with summary of CI failures

6 participants