Skip to content

Remove the constrained friend declaration from proxy - #101

Merged
mingxwa merged 1 commit into
ngcpp:feature/v5from
mingxwa:user/mingxwa/drop-proxy-friend
Nov 15, 2026
Merged

mingxwa merged 1 commit into
ngcpp:feature/v5from
mingxwa:user/mingxwa/drop-proxy-friend

Conversation

@mingxwa

@mingxwa mingxwa commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

**NOTE**: This targets `feature/v5`.

- Removed `template <facade F2, class MP2> friend class proxy;` from `proxy`. Clang 20 and 21 crash when a translation unit that imports `proxy.v5` names a `proxy` specialization after one has been instantiated ([CI run](https://github.com/ngcpp/proxy/actions/runs/43559573378)). The trigger is a constrained friend redeclaration of a class template in the global module fragment, a variant of llvm/llvm-project#88400 that Clang 22 no longer has.
- Routed the access to the storage and metadata of another `proxy` specialization through `detail::proxy_helper`.
- Added a module test that names `proxy<Foo>` again after it is instantiated.
@mingxwa
mingxwa merged commit b422d2b into ngcpp:feature/v5 Nov 15, 2026
20 checks passed
@mingxwa
mingxwa deleted the user/mingxwa/drop-proxy-friend branch November 15, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant