Repository navigation
Remove the constrained friend declaration from proxy - #101
Merged
Merged
Conversation
**NOTE**: This targets `feature/v5`. - Removed `template <facade F2, class MP2> friend class proxy;` from `proxy`. Clang 20 and 21 crash when a translation unit that imports `proxy.v5` names a `proxy` specialization after one has been instantiated ([CI run](https://github.com/ngcpp/proxy/actions/runs/43559573378)). The trigger is a constrained friend redeclaration of a class template in the global module fragment, a variant of llvm/llvm-project#88400 that Clang 22 no longer has. - Routed the access to the storage and metadata of another `proxy` specialization through `detail::proxy_helper`. - Added a module test that names `proxy<Foo>` again after it is instantiated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
template <facade F2, class MP2> friend class proxy;fromproxy. Clang 20 and 21 crash when a translation unit that importsproxy.v5names aproxyspecialization after one has been instantiated (CI run). The trigger is a constrained friend redeclaration of a class template in the global module fragment, a variant of [Clang] [ICE] [crash-on-valid] clang frontend crashes when using modules, self-friend template with concepts llvm/llvm-project#88400 that Clang 22 no longer has.proxyspecialization throughdetail::proxy_helper.proxy<Foo>again after it is instantiated.