Skip to content

fix(ci): make the release workflow agree with the actions lockfile - #1158

Merged
cameri merged 1 commit into
mainfrom
fix/release-lockfile
Nov 17, 2026
Merged

cameri merged 1 commit into
mainfrom
fix/release-lockfile

Conversation

@chappie-daemon

@chappie-daemon chappie-daemon commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Root cause

nostream@3.16.0 published with no container image. Run 43985051541 ended in startup_failure — no job was ever created — because the workflow file itself will not parse:

failed to parse workflow: Invalid dependency lockfile ".github/workflows/actions.lock":
workflow ".github/workflows/release.yml" references actions not present in the lockfile:
  docker/login-action@f054a8b539a109f9f41c372932f1ae047eff08c9,
  docker/metadata-action@98669ae865ea3cffbcbaa878cf57c20bbf1c6c38,
  docker/build-push-action@ad44023a93711e3deb337508980b4b5e9bcdc5dc

release.yml pinned those three actions by full commit SHA; actions.lock (added in #1117) records them by tag. The lockfile check compares the two strings, so the mismatch makes the file unparseable. The three actions were the only mismatch — the other six workflows already reference the tags their entries record, and the last good release (nostream@3.15.3, run 43552967942) predates #1117.

What changed

Three uses: lines in .github/workflows/release.yml, regenerated with gh actions-lock v0.4.1:

before after
login docker/login-action@f054a8b539a109f9f41c372932f1ae047eff08c9 docker/login-action@v1.10.0
metadata docker/metadata-action@98669ae865ea3cffbcbaa878cf57c20bbf1c6c38 docker/metadata-action@v3.3.0
build-push docker/build-push-action@ad44023a93711e3deb337508980b4b5e9bcdc5dc docker/build-push-action@v2.5.0

The lockfile is unchanged: its entries for those three actions already recorded exactly those commits (sha1-f054a8b…, sha1-98669ae…, sha1-ad44023…). Nothing about which commit runs has moved; the workflow now names the tag, and the lockfile pins the commit, which is the shape this repo adopted in #1117 and the shape the other six workflows already use.

gh actions-lock --verify now reports All 7 workflows valid.

Why the SHA pins could not stay

Keeping the SHAs in uses: and rewriting the lockfile to match was tried first, and the tool rejects it:

lock entry for docker/build-push-action@ad44023a9371 records ref ad44023a9371,
a commit SHA rather than the tag or branch it was taken from; the Actions backend
rejects this pin

So the platform does not accept a lock entry whose ref is a bare SHA either. The only parseable arrangement is tag in the workflow, commit in the lockfile — which is what gh actions-lock writes, and what every other workflow here already does. Supply-chain behaviour is unchanged: the commit is pinned, and the lockfile is what the runner enforces.

Verification

Dispatched the documented recovery path (#964) against this branch:

gh workflow run release.yml -R cameri/nostream --ref fix/release-lockfile -f 'tag=nostream@3.16.0'
  • run 43985599542 — completed success, no startup_failure; job Build and push container image succeeded;
  • the run logged publishing: ghcr.io/cameri/nostream:3.16.0,ghcr.io/cameri/nostream:latest;
  • the registry itself answers for the tag, checked anonymously rather than from the job colour:
GET https://ghcr.io/v2/cameri/nostream/manifests/3.16.0  →  200
docker-content-digest: sha256:463faf39468679fd09005572beaf112c012c7c19b0b16ce96eb07727e8726ffe

3.15.3 still resolves (sha256:a1486a36…), so nothing was overwritten.

Not changed

gh actions-lock warns that wagoid/commitlint-github-action@v5.5.1 ships a container image tagged rather than pinned by digest. The lockfile pins action commits, not image digests, so that warning is upstream's to clear; it is a warning, not an error, and does not affect parsing.

Summary by CodeRabbit

  • Chores
    • Updated the automated release workflow to use versioned action references. Existing workflow inputs and image-tag behavior remain unchanged. This update does not change application features or public interfaces; it affects release automation configuration only.

release.yml pinned docker/login-action, docker/metadata-action and
docker/build-push-action by full commit SHA, while actions.lock (added in
#1117) records them by tag. The lockfile check parses the workflow against
the lock, so it refused the whole file — "references actions not present in
the lockfile" — and every release run since then ended in startup_failure
before a job was created. nostream@3.16.0 is published with no image.

Regenerated with gh actions-lock v0.4.1 rather than hand-edited. It rewrites
the three uses: lines to the tag its entries record: v1.10.0, v3.3.0, v2.5.0.
The commits are the same ones the SHAs named — f054a8b, 98669ae, ad44023 —
because the lockfile is where a commit is pinned; a lock entry whose ref is a
bare SHA is rejected too ("records ref ad44023a9371, a commit SHA rather than
the tag or branch it was taken from; the Actions backend rejects this pin").
The three actions were the only mismatch; the other six workflows already
referenced the tags their entries record, so the lockfile needed no change.

Also records what the tool cannot: wagoid/commitlint-github-action ships a
container image, and the lockfile pins action commits rather than image
digests, so it warns on every run. That is upstream's to fix.
@changeset-bot

changeset-bot Bot commented Nov 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d287349

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The release workflow now references Docker login, metadata, and build-push actions by version tags. Existing workflow inputs and image-tag computation are unchanged.

Changes: Release workflow

Layer / File(s) Summary
Update release action references
.github/workflows/release.yml
The Docker login and metadata steps use v1.10.0 and v3.3.0. The build-push step uses v2.5.0. Their configuration remains unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: Minimal · up to d2873

The release workflow now references the Docker actions by version tag, matching the other workflows and the lockfile. No concrete risk was identified, so the change looks ready to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the release workflow and the actions lockfile, which matches the changeset. The PR replaces three pinned commit SHAs in .github/workflows/release.yml with the version tags recorded in …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the release workflow and the actions lockfile, which matches the changeset. The PR replaces three pinned commit SHAs in .github/workflows/release.yml with the version tags recorded in the lockfile (docker/login-action@v1.10.0, docker/metadata-action@v3.3.0, docker/build-push-action@v2.5.0), so the release workflow agrees with the lockfile format used by the other workflows. The title is specific and concise and states the primary change.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the tags in place
Three actions hop to versions new
The workflow keeps its settings still
The image tags stay as before
I nibble greens and cheer the change

Recent review info

Automatic approval policy

Commit: d287349a0a4d.

Setting Effective value Source
Automatic approvals Enabled Global configuration
Merge risk Minimal Global configuration
Security risk Not set Global configuration

Not set means no limit was configured after inheritance. Use @coderabbitai configuration to inspect the resolved settings and their sources.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9eb30cc7-68ab-4204-9ee0-85fb83802609
Commits

Reviewing files that changed from the base of the PR and between aa3656d and d287349.

Files selected for processing: 1

  • .github/workflows/release.yml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Updates three Docker action references in release.yml to match actions.lock.

  • The release workflow can build images with its locked Docker actions.

Reviews (1) · Last reviewed commit: "fix(ci): make the release workflow agree..." · Reviewed by Greptile

@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 43985800459

Coverage decreased (-0.005%) to 79.242%

Details

  • Coverage decreased (-0.005%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 13890
Covered Lines: 11473
Line Coverage: 82.6%
Relevant Branches: 7451
Covered Branches: 5438
Branch Coverage: 72.98%
Branches in Coverage %: Yes
Coverage Strength: 677.66 hits per line

💛 - Coveralls

@cameri
cameri merged commit 026bd00 into main Nov 17, 2026
20 of 22 checks passed
@cameri
cameri deleted the fix/release-lockfile branch November 17, 2026 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants