Repository navigation
Show why removing an environment takes long, and stop when it fails - #71
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bref removeshowed "removing" until the environment disappeared, with nothing else, and waited forever when AWS failed to delete it.It now reads
removalfrom the environment (brefphp/cloud#479):It checks every 3 seconds instead of every second. An older Bref Cloud, without
removal, gives the previous behaviour.When Bref Cloud says
finishing(only AWS releasing the network interfaces of functions that ran in a VPC is left, around 20 minutes), the command stops waiting, says "removed" and prints why the environment is still finishing in the background.