Repository navigation
Conversation
Boolean options (e.g. linenums) set via attr_list were passed to the escape helper as bool objects, raising TypeError when codehilite is not enabled. Serialize them the way the serializer does. Fixes Python-Markdown#1713. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1713. When
fenced_codeandattr_listare enabled butcodehiliteis not, boolean options such aslinenums=truewere passed to_escape_attrib_htmlasboolobjects, raisingTypeError: cannot serialize True. Following the plan in the issue thread, values are now serialized as the serializer would:None->key;True-> barekeyfor HTML boolean attributes withhtmloutput, otherwisekey="key";False-> omitted.Test plan: added two tests in
tests/test_syntax/extensions/test_fenced_code.py(fail before, pass after); fullpython -m unittest discover testspasses; flake8 clean on changed files.AI Assistance Disclosure
No AI tools were used in preparing this PR.
AI tools were used and I have disclosed which ones, and have fully reviewed and verified their output.
AI tools were use to assist with the following:
Checklist