Repository navigation
test: a real round trip in the tunnel e2e (#281) - #283
Merged
Merged
Conversation
tests/e2e.sh puts a netem delay of DELAY_MS (default 30 ms each way) on the links of the emulator, the hub and the Linux edge: 60 ms between the box and the hub, as camex's throughput test. tc comes from a small image of its own (tests/netem, decoder-netem, built on the first run). With the delay the video rate check tells the camex versions apart: camex 4.0.0 over TCP got 14 KB/s and failed, 4.0.1 passes (974 KB/s on API 34). Closes #281
PR Summary by QodoAdd realistic network delay to tunnel end-to-end tests
AI Description
Merge Risk
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can type 'qodo, fix this' on a finding and the fix lands right on your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #281.
tests/e2e.shputs a netem delay on the links of the emulator, the hub and the Linux edge:DELAY_MSeach way, default 30 ms, so 60 ms between the box and the hub (as camex'sdocker/test-e2e-throughput.sh);DELAY_MS=0turns it off.compot/crosshas notc, so it comes from a small image of its own:tests/netem/Dockerfile(alpine:3.22 + iproute2), built asdecoder-netemon the first run and cached;NETEM_IMAGEoverrides it. The emulator's own-netdelaywas tried first and had no effect.With the delay the video rate check (100 KB/s or more through
tun0) tells the camex versions apart.docs/testing.mddescribes the delay. Tests and docs only: no version bump.Tests (local, Docker; the ping through the tunnel to the edge shows ~121 ms):
TRANSPORT=TCP tests/e2e.sh 34TRANSPORT=TCP tests/e2e.sh 34TRANSPORT=TCP tests/e2e.sh 21tests/e2e.sh 34(UDP)