You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: snapshot note in a black cell on two short lines (2.24.1) - #278
On the SberBox the note of 2.24.0 (#277) in a black snapshot cell was one line and got cut off in a 2×2 grid ("black in the copy: a dark picture, or video this device does not let…").
Now two lines, centred: "black in the copy:" / "a dark picture, or video this device cannot copy". At the note's size the second line is about 790 px wide in a 952 px cell (2×2 of 1920) and about 530 px in a 632 px cell (3×3), so it fits.
Version 2.24.1 (versionCode 58), CHANGELOG, docs/debug.md.
Checked locally in compot/android:2026.10: testDebugUnitTest 407/407, lintDebug no new findings. Checked on the SberBox with the release (a debug build there would need a reinstall that drops its settings).
• Split the black-copy warning into two centred lines so it fits snapshot grid cells.
• Document the revised warning and release the fix as version 2.24.1.
Merge Risk 🟢 Low
Evidence: Partial. The provider did not establish the exact full-PR diff base and head revisions; the supplied changed-file inventory and patch were used as the complete change set. The provider did not establish the exact full-PR diff revisions. The report lists 14 more gaps.
Blast radius 🟢 Low💥 1 capability
1 affected end-to-end capability after fault-specific containment; implementation boundaries do not widen its functional scope.
The changed behavior is the user-visible diagnostic annotation in the debug snapshot.
The caller exposes the resulting JPEG through /snapshot.jpg, while the note is drawn only for black copied cells; these are producer and delivery hops of one bounded debug-snapshot capability, not independent capabilities.
staticfinalString[] NOT_COPIED = {
"black in the copy:", "a dark picture, or video this device cannot copy"};
Behavioral complexity 🟢 Low🧩 Straightforward
Before, one sentence was ellipsized and drawn once.
After, a fixed two-element message is iterated, with the existing ellipsize and text-drawing infrastructure reused for each line.
The new correctness condition is that the two lines remain centered within the cell and independently fit its width; this is a direct formatting/layout rule with no new state machine, compatibility protocol, concurrency behavior, or coordinated invariant.
staticfinalString[] NOT_COPIED = {
"black in the copy:", "a dark picture, or video this device cannot copy"};
Assessed commit c4060a8
> Snapshot assessment: the current PR revision could not be verified.
Diagram
graph TD
A["Snapshot request"] --> B["PixelCopy frames"] --> C{"Black copy?"} -->|yes| D["Two-line note"] --> E["Snapshot JPEG"]
C -->|no| E
Loading
High-Level Assessment
Keep the explicit two-line message: the warning is fixed text, and a deliberate break makes its layout predictable in the target grids. Automatic wrapping would add complexity without a clear benefit here.
Files changed (4) +22 / -11
Bug fix (1) +13 / -8
Snapshots.javaCentre the black-copy warning on two lines+13/-8
Centre the black-copy warning on two lines
• Replaces the single long warning with two shorter lines. Draws each line centred in the cell, with per-line ellipsizing as a fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the SberBox the note of 2.24.0 (#277) in a black snapshot cell was one line and got cut off in a 2×2 grid ("black in the copy: a dark picture, or video this device does not let…").
Now two lines, centred: "black in the copy:" / "a dark picture, or video this device cannot copy". At the note's size the second line is about 790 px wide in a 952 px cell (2×2 of 1920) and about 530 px in a 632 px cell (3×3), so it fits.
Version 2.24.1 (versionCode 58), CHANGELOG,
docs/debug.md.Checked locally in
compot/android:2026.10:testDebugUnitTest407/407,lintDebugno new findings. Checked on the SberBox with the release (a debug build there would need a reinstall that drops its settings).